Fix the ending char checking condition#97
Open
poppinlp wants to merge 1 commit intohandshake-org:masterfrom
poppinlp:ending-condition
Open
Fix the ending char checking condition#97poppinlp wants to merge 1 commit intohandshake-org:masterfrom poppinlp:ending-condition
poppinlp wants to merge 1 commit intohandshake-org:masterfrom
poppinlp:ending-condition
Conversation
Fix the ending char checking condition.
Member
|
Thanks for the review and the bump @Ely68 and for the PR, @poppinlp sorry no one has gotten to review this. I tried running |
Author
|
Wow, it's really a long time ago PR. I remember I met some issues at that time. But, actually, I don't have that env right now. T_T |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For windows, we will get LFCR when we press ENTER. In your logic, you only check the
data[0], so it's LR for windows.Or maybe you could change the switch condition here not just use
data[0].