Skip to content

Fix the ending char checking condition#97

Open
poppinlp wants to merge 1 commit intohandshake-org:masterfrom
poppinlp:ending-condition
Open

Fix the ending char checking condition#97
poppinlp wants to merge 1 commit intohandshake-org:masterfrom
poppinlp:ending-condition

Conversation

@poppinlp
Copy link
Copy Markdown

@poppinlp poppinlp commented Mar 6, 2020

For windows, we will get LFCR when we press ENTER. In your logic, you only check the data[0], so it's LR for windows.
Or maybe you could change the switch condition here not just use data[0].

Fix the ending char checking condition.
@pinheadmz
Copy link
Copy Markdown
Member

Thanks for the review and the bump @Ely68 and for the PR, @poppinlp sorry no one has gotten to review this.

I tried running hs-airdrop without any changes (master branch) in Windows Command Prompt, Ubnutu for Windows, WSL and git-bash, and didn't have any issues on those four entering a passphrase for a private key and hitting "enter". This PR looks right and is certainly minimal so it's probably good to merge, but you could help me reproduce the problem on windows? What was the environment?

@poppinlp
Copy link
Copy Markdown
Author

poppinlp commented Jun 9, 2021

Wow, it's really a long time ago PR. I remember I met some issues at that time. But, actually, I don't have that env right now. T_T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants