ci: Lock npm version and add brew prefix#133
Merged
Nathanwoodburn merged 1 commit intohandshake-org:masterfrom Mar 13, 2026
Merged
ci: Lock npm version and add brew prefix#133Nathanwoodburn merged 1 commit intohandshake-org:masterfrom
Nathanwoodburn merged 1 commit intohandshake-org:masterfrom
Conversation
Falci
reviewed
Mar 13, 2026
.github/workflows/test.yml
Outdated
Comment on lines
+38
to
+39
| node-version: 20 | ||
| check-latest: false |
Member
There was a problem hiding this comment.
This can work as a temporary fix.
Maybe we should create an issue to revisit this.
Member
Author
There was a problem hiding this comment.
This should be fixed now by increasing the HSD version in the integration testing https://github.com/Nathanwoodburn/hnsd/blob/cb1ab833ff8329d42a8d68e44e7c136196381d40/integration/package.json#L12
Falci
approved these changes
Mar 13, 2026
Lower hsd versions use outdated bdb which fails to compile on node versions >20
Nathanwoodburn
force-pushed
the
fix/github_actions
branch
from
dc5b0e8 to
cb1ab83
Compare
Falci
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix actions to stop the consistent failures. Bumps hsd to the latest version to stop compilation errors on node versions newer than 20