rs: do not strip authority section in response#126
Open
rithvikvibhu wants to merge 1 commit intohandshake-org:masterfrom
Open
rs: do not strip authority section in response#126rithvikvibhu wants to merge 1 commit intohandshake-org:masterfrom
rithvikvibhu wants to merge 1 commit intohandshake-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes buffrr/letsdane#1
Recursive resolvers should return the NSEC record in the AUTHORITY section for successful verification of wildcard records. Trying to do so right now (in both hsd and hnsd) fail with
noqname proof not found.more info: https://datatracker.ietf.org/doc/html/rfc5155#section-8.8
Live example
*.home.htoolsis a wildcard TLSA record in zonehtoolsat 129.153.177.220.Start hnsd with:
./hnsd -p 2 -r 127.0.0.1:9592 -n 127.0.0.1:9591 -t -x ~/.hnsdWithout this PR:
With this PR: