Add DiscussionForumPosting structured data type option#31
Open
Add DiscussionForumPosting structured data type option#31
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Closes #29
JSON-LDの構造化データ型を
QAPage(既存)とDiscussionForumPostingから選択できるようにしました。変更内容
AdminSetting.php
OPTION_STRUCTURED_DATA_TYPEを追加StructuredData.php
get_json()を設定値に基づいてget_qa_json()/get_discussion_json()にディスパッチするように変更get_discussion_json()を新規追加(DiscussionForumPosting型のJSON-LD出力)get_person_json()ヘルパーでauthor生成を共通化hamethread_json_ld/hamethread_should_output_json_ldは維持翻訳ファイル
検証方法