Draft
Conversation
SLACK_CHANNEL does not work when setting up Slack app. Supposed to be separate tool and door channels here to post messages correctly.
Wrong file name "docker-run.sh". Supposed to be "docker_run.sh" to work.
user_X "entered through the" Y_door is a bit long in reality and clutters the log. Just "opened" is enough
Added Timezone selection to fix incorrect time display in the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In config_docker.json SLACK_CHANNEL does not work when setting up a Slack app. Supposed to be separate tool and door channels here to post messages correctly.
In the installation instructions file name in suggested command is wrong
In the text posted to Slack channel phrase XX "entered through the" YY clutters the log and is redundant. Just "opened" will suffice.
User is not able to set up time zone in docker container (default +0:0) which results in incorrect time displayed in the logs and key activations. Added a timezone selection to Dockerfile