Open
Conversation
Owner
|
Thank you @robgonnella for the PR! 👍 It would be great to make the tests run in a browser. However, there's couple of things here that I think needs to be addressed before this can be merged:
|
3410f94 to
2d53bfa
Compare
Author
|
Ok thought about it a bit and took a better approach using
|
2d53bfa to
b88afe9
Compare
Updates test infrastructure to use grunt-mocha / phantomJS to run the tests in a browser. Resolves Issue: haadcode#8
b88afe9 to
86cdad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs relevant tests in browser using puppeteer package. Results
are captured in a snapshot with duration information hidden and
compared against an image of the last known passing image run. This
is a bit brittle in that it requires manually updating the current
passing screenshot when browser tests are modified.
Resolves Issue: #8