Add script to simplify adding a missing type.#91
Conversation
|
I'm not very convinced about this code generation approach. It will lead to inconsistency in the way to declare matches in the library unless all matches are ported to be defined the same way consistently within the package, which is not something I'm very inclined to. Typically, dynamic code generation has its advantages where relevant boilerplate steps are involved, but I don't see much value here. I would rather prefer the explicitness of persisted and evaluable code without any code generation process involved. |
|
I get your point about the inconsistencies. You mean the comparison by I disagree on the boilerplate because in order to add 4 bytes, one extension, and a mime type I have to write about 8 lines of code (that only differs in the mentioned properties), add the type to the README, and to I don't get this point:
The generated code is committed (I did all my PRs using this generation appraoch) |
Should simplify: #45