Open
Conversation
Collaborator
|
I think I know what the issue is. I haven't actually debugged it though This right here where the result gets returned starboard-python/src/worker/pyodide-worker.ts Line 136 in 0fb45fd starboard-python/src/worker/object-proxy.ts Line 269 in 0fb45fd |
Collaborator
|
I took a closer look at it. I suppose the kernel could/should automatically handle that. This could be done around here starboard-python/src/worker/kernel.ts Line 118 in 867df3a Though, ideally at some point https://github.com/hoodmane/synclink would be ready for production use. And then we could use that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce locally you can try the steps here.