Refactor TextSearch classes for improved clarity and semantic accuracy#2416
Open
annuaicoder wants to merge 1 commit intogunthercox:masterfrom
Open
Refactor TextSearch classes for improved clarity and semantic accuracy#2416annuaicoder wants to merge 1 commit intogunthercox:masterfrom
annuaicoder wants to merge 1 commit intogunthercox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
TextSearchandIndexedTextSearchclasses to improve maintainability, accuracy, and readability. Key improvements include:BaseTextSearchclass to remove duplicate logicLevenshteinDistancewithSpacySimilarity(if available) for better semantic comparisonsWhy
The previous implementation had redundant code across classes and relied solely on Levenshtein distance, which does not capture meaning. This update leverages built-in ChatterBot capabilities to improve results while making the code more maintainable.
Notes
in_response_tois missingLet me know if you’d like this to support a fallback to
LevenshteinDistanceifSpacySimilarityisn’t available.