Open
Conversation
84c9068 to
f967968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request organizes and cleans up the
Dockerfilefor better readability and maintainability. The following changes were made:alpineimage since it was only used to copy the source codecomposerandphpversions to avoid breaking distro or software updatescurlandvim-tinyDockerfilein a source code, dependencies, config, runtime model improving readabilityconfig,coursesandvideodirectories ensuring configuration persistence even if the end-user forgets to assign a named volumeIdeally the Debian based PHP image should be replaced with 8.3-alpine3.21 which would offer a far more lightweight image but I decided against it for now to avoid breaking any current setups that rely on Debian. Let me know if you need anything changed.