Open
Conversation
Sahit, please try running ` roslaunch buzzmobile simulation_test.launch` locally and seeing what happens. I get errors that the controller manager cannot find dependencies, and I want to see if that's true for you as well. I think this implies some issues in either the urdf or in sim_car_interface.cpp, but I'm not 100% sure of that.
Pip and pytest provide system binary aliases (`pip` and `pytest`). These are hardcoded to use different versions of python than those in the virtualenv. Swapping this to `python -m BINARYNAME` forces use of the virtualenv-local python version, in our case forcing python2 vs. my system's python3 default.
Member
Author
|
Also whoever merges this, please squash it its gross. |
chsahit
reviewed
Nov 15, 2017
| try: | ||
| import googlemapskey as gmpskey | ||
| except ImportError as e: | ||
| pass |
Member
There was a problem hiding this comment.
are you sure we want to fail silently here? Maybe a warning message that says they should init the googlemapskey. If you're ok with that I can push it to this branch.
Member
Author
There was a problem hiding this comment.
a "This should be a test and you should be faking gmpskey" warning wouldn't be a terrible thing.
| </group> | ||
|
|
||
| <!-- Start gazebo server, load world, optionally start viz client --> | ||
| <node pkg="gazebo_ros" name="gazebo" type="gzserver" |
Member
There was a problem hiding this comment.
I'm getting a bunch of warnings on running this saying "deprecated syntax". can you replicate?
Member
Author
There was a problem hiding this comment.
I don't see those, no.
Member
There was a problem hiding this comment.
Oh wait I'm testing these on kinetic, pushing a reminder to myself to test it on indigo in my VM tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL.
ci_scripts/simulationpasses locally, and so doesci_scripts/unittest, this feels stabler than it was before.I'm a bit confused by the horrendously long timeout required in the simulation test, but it's necessary.
Also running with
roslaunch buzzmobile simulation_test.launch gzclient:=Trueworks, which I don't think did for me before, but I have no clue why that is (also note I made some related changes in pyros).I'd like to be able to see rviz output as well, @Sahit, do you know if there's a way to somehow show rviz data (or just do bits of buzzmobile namespaced topic visualization in gazebo)?