Merged
Conversation
Author
|
This might in some weird way relate to #1 since I think that PR is attempting to address some of the same issues. That in certain places we take a digest algorithm and try to look up info in the lookup tables which previously only had signature algorithm oids |
groob
approved these changes
Jul 5, 2018
Owner
|
This will do for now to fix the issue. We can make a cleaner refactor of all these components later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the comments on this bug micromdm/micromdm#441 (comment)
We were not always correctly matching the SignedData digestAlgorithm with the information in the SignerInfo and we weren't setting the digestAlgorithm in the SignerInfo to a real digest algorithm. This should fix the error of enrollment not working on iOS.
I tested on macOS 10.13.4, 10.10 and iOS 11.4, 9.3.3