Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates @apollo/server to version 5.5.0 and nodemailer to version 8.0.4. The major version upgrade for nodemailer may cause type inconsistencies or build failures if the corresponding @types/nodemailer package is not updated or removed in favor of built-in types.
| "ioredis": "5.8.2", | ||
| "mjml": "4.14.0", | ||
| "nodemailer": "7.0.11", | ||
| "nodemailer": "8.0.4", |
There was a problem hiding this comment.
Upgrading nodemailer to a new major version (v8.0.4) is a significant change that likely includes breaking changes. The corresponding type definitions in @types/nodemailer are still for an older version (7.0.4), which can lead to type inconsistencies, build failures, or runtime errors.
If nodemailer@8.0.4 includes its own TypeScript definitions (which is common for major rewrites), the @types/nodemailer package should be removed to avoid conflicts. If it doesn't, @types/nodemailer needs to be updated to a version compatible with nodemailer@8.0.4.
There was a problem hiding this comment.
not yet released but types stay the same
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
1 participant
No description provided.