Skip to content

fix: switch current operation request to network-only to prevent caching #7856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mskorokhodov wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: switch current operation request to network-only to prevent caching #7856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web/app/src/lib/hooks/laboratory/use-current-operation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export function useCurrentOperation(props: {
id: operationIdFromSearch!,
},
pause: !operationIdFromSearch,
requestPolicy: 'network-only',
Comment on lines 39 to +42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the pause option makes the non-null assertion (!) on operationIdFromSearch currently safe, it's better to avoid it as per our coding guidelines to prevent potential bugs. For consistency with useCurrentOperationWithFetchingState in the same file, please provide a fallback value.

Suggested change
id: operationIdFromSearch!,
},
pause: !operationIdFromSearch,
requestPolicy: 'network-only',
id: operationIdFromSearch || '',
},
pause: !operationIdFromSearch,
requestPolicy: 'network-only',
References
  1. Avoid using the non-null assertion operator (!) outside of test files, as it can lead to subtle bugs.

});
// if operationId is undefined `data` could contain previous state
return operationIdFromSearch ? data?.target?.documentCollectionOperation : null;
Expand Down
Loading