Filter instead of failing for nil string values#503
Open
amaierhofer wants to merge 1 commit intographiti-api:mainfrom
Open
Filter instead of failing for nil string values#503amaierhofer wants to merge 1 commit intographiti-api:mainfrom
amaierhofer wants to merge 1 commit intographiti-api:mainfrom
Conversation
amaierhofer
force-pushed
the
fix-nil-handling-in-eql-filter
branch
6 times, most recently
from
af24aa1 to
d6f5589
Compare
amaierhofer
changed the title
amaierhofer
changed the title
amaierhofer
force-pushed
the
fix-nil-handling-in-eql-filter
branch
from
d6f5589 to
af24aa1
Compare
This currently fails with `Unsupported argument type: NilClass. Construct an Arel node instead.` when the scope is resolved. Prior art from graphiti-api#410
amaierhofer
force-pushed
the
fix-nil-handling-in-eql-filter
branch
from
af24aa1 to
b03792d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a filter like
/api/people?filter[first_name][eq]=currently fails withUnsupported argument type: NilClass. Construct an Arel node instead.when the scope is resolved.This PR would allow to filter for
nilwith the above request. The additionalpresencecalls are necessary to make the inversion of the filter work as well.I am unsure about what to do about the error requiring
ostructon some of the ci runs. See also #410 for a similar attempt at implementing that