Add tests for copyBufferToBuffer overloads#4310
Merged
Conversation
Collaborator
Author
|
Note that gpuweb/types#180 is required to make bots happy. |
beaufortfrancois
force-pushed
the
copyBufferToBuffer
branch
from
eb770bf to
374fe04
Compare
Collaborator
Author
|
I've updated this PR with @webgpu/types version 0.1.60. |
kainino0x
reviewed
Apr 2, 2025
Collaborator
Author
|
Thanks @kainino0x! I've addressed all your feedback. |
kainino0x
approved these changes
Apr 2, 2025
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/gecko-dev
that referenced
this pull request
Apr 10, 2025
…8206c7 r=#webgpu-reviewers! - Tier 2 changes: - Apparent-but-not-actually regressions: - `webgpu:api,operation,command_buffer,copyBufferToBuffer:*` was expanded to include the simpler overload for `GPUCommandEncoder.copyBufferToBuffer` with no offsets and optional size in [gpuweb/cts#4310](gpuweb/cts#4310), which we have not yet added. Tracking in bug 1959728. - `webgpu:shader,execution,expression,call,builtin,workgroupUniformLoad:types:*` expanded with coverage that fails on Linux. - Tier 3 changes: - Some cases for `webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:no_atomics:*` were removed. - Some `stencil*` texture format coverage was moved to new test: `webgpu:api,operation,rendering,stencil:stencil_accumulation:*` Differential Revision: https://phabricator.services.mozilla.com/D245101
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 17, 2025
…8206c7 r=webgpu-reviewers,teoxoy - Tier 2 changes: - Apparent-but-not-actually regressions: - `webgpu:api,operation,command_buffer,copyBufferToBuffer:*` was expanded to include the simpler overload for `GPUCommandEncoder.copyBufferToBuffer` with no offsets and optional size in [gpuweb/cts#4310](gpuweb/cts#4310), which we have not yet added. Tracking in bug 1959728. - `webgpu:shader,execution,expression,call,builtin,workgroupUniformLoad:types:*` expanded with coverage that fails on Linux. - Tier 3 changes: - Some cases for `webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:no_atomics:*` were removed. - Some `stencil*` texture format coverage was moved to new test: `webgpu:api,operation,rendering,stencil:stencil_accumulation:*` Differential Revision: https://phabricator.services.mozilla.com/D245101
globau
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 17, 2025
…8206c7 r=webgpu-reviewers,teoxoy - Tier 2 changes: - Apparent-but-not-actually regressions: - `webgpu:api,operation,command_buffer,copyBufferToBuffer:*` was expanded to include the simpler overload for `GPUCommandEncoder.copyBufferToBuffer` with no offsets and optional size in [gpuweb/cts#4310](gpuweb/cts#4310), which we have not yet added. Tracking in bug 1959728. - `webgpu:shader,execution,expression,call,builtin,workgroupUniformLoad:types:*` expanded with coverage that fails on Linux. - Tier 3 changes: - Some cases for `webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:no_atomics:*` were removed. - Some `stencil*` texture format coverage was moved to new test: `webgpu:api,operation,rendering,stencil:stencil_accumulation:*` Differential Revision: https://phabricator.services.mozilla.com/D245101
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 23, 2025
…8206c7 r=webgpu-reviewers,teoxoy - Tier 2 changes: - Apparent-but-not-actually regressions: - `webgpu:api,operation,command_buffer,copyBufferToBuffer:*` was expanded to include the simpler overload for `GPUCommandEncoder.copyBufferToBuffer` with no offsets and optional size in [gpuweb/cts#4310](gpuweb/cts#4310), which we have not yet added. Tracking in bug 1959728. - `webgpu:shader,execution,expression,call,builtin,workgroupUniformLoad:types:*` expanded with coverage that fails on Linux. - Tier 3 changes: - Some cases for `webgpu:shader,validation,expression,call,builtin,workgroupUniformLoad:no_atomics:*` were removed. - Some `stencil*` texture format coverage was moved to new test: `webgpu:api,operation,rendering,stencil:stencil_accumulation:*` Differential Revision: https://phabricator.services.mozilla.com/D245101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for copyBufferToBuffer overloads that allow developers to optionally pass offsets and size in gpuweb/gpuweb#5098
Those are currently gated behind the WebGPUExperimentalFeatures blink runtime feature in Chromium. See https://chromium-review.googlesource.com/c/chromium/src/+/6401714
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.