Add aarch64 Linux support (DGX Spark / GB10)#51
Conversation
- Add aarch64-unknown-linux-gnu build target to the release workflow - Add .cargo/config.toml to configure the cross-linker for aarch64 - Update install.sh to detect arm64/aarch64 and download the correct binary (popcorn-cli-linux-aarch64.tar.gz) instead of the x86-64 build
There was a problem hiding this comment.
Pull request overview
Adds ARM64 (aarch64) Linux support to the release pipeline and installer so Popcorn CLI can be installed and run on machines like the NVIDIA GB10 / DGX Spark.
Changes:
- Extend the GitHub Actions build matrix to produce a
popcorn-cli-linux-aarch64.tar.gzrelease asset. - Add a Cargo target linker config for
aarch64-unknown-linux-gnuto support cross-linking on CI. - Update
install.shto detectaarch64/arm64on Linux and download the matching release artifact.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
install.sh |
Detects ARM64 Linux and selects the linux-aarch64 release asset automatically. |
.github/workflows/build.yml |
Builds and publishes an additional ARM64 Linux tarball as a release asset. |
.cargo/config.toml |
Configures the cross-linker for aarch64-unknown-linux-gnu builds (CI/local). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm not sure I can quite merge this as is just because I don't have a machine to test this on and I'm worried that we'll get some glib issues Might be best to just tell people to build from source on any unconventional hardware |
|
Can someone from NVIDIA please send this man a DGX spark GB10? It would really expand the community. Can you also send me one while you're at it 😅 |
|
Changed your PR so we natively compile on ARM64 instead of cross compiling |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🙌🙌🙌 |
Summary
aarch64-unknown-linux-gnuto the release build matrix, producingpopcorn-cli-linux-aarch64.tar.gz.cargo/config.tomlto configureaarch64-linux-gnu-gccas the cross-linker on GitHub Actions runnersinstall.shto detectaarch64/arm64on Linux and download the correct binary automaticallyMotivation
The pre-built
popcorn-cli-linux.tar.gzis x86-64 only and does not run on ARM Linux machines such as the NVIDIA GB10 DGX Spark. This PR makes the install script work out of the box on those systems with no manual steps required.Test plan
popcorn-cli-linux-aarch64.tar.gzsuccessfullycurl -fsSL .../install.sh | bashon an aarch64 Linux machine and confirmpopcorn --versionworks