kernel.py: maternp_covariance_ii_or_tt(): Remove small nugget#2
Open
jbect wants to merge 1 commit intogpmp-dev:mainfrom
Open
kernel.py: maternp_covariance_ii_or_tt(): Remove small nugget#2jbect wants to merge 1 commit intogpmp-dev:mainfrom
jbect wants to merge 1 commit intogpmp-dev:mainfrom
Conversation
gpmp-dev
force-pushed
the
main
branch
3 times, most recently
from
ba11049 to
ee98278
Compare
gpmp-dev
force-pushed
the
main
branch
2 times, most recently
from
7982c9d to
daa1af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest to remove the (small) nugget in
maternp_covariance_ii_or_tt(), which IMHO serves no real purpose.The way I see it: either the correlation matrix is properly conditioned, and the small nugget won't make a difference, or it is not, and then it is very unlikely that such small nugget will restore a proper conditioning.
Just my two cents.