Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Fix js exception and broken link in report html#741

Open
treeskar wants to merge 2 commits intogotwarlost:masterfrom
treeskar:master
Open

Fix js exception and broken link in report html#741
treeskar wants to merge 2 commits intogotwarlost:masterfrom
treeskar:master

Conversation

@treeskar
Copy link

JS Exception fix - happened when I am running istanbul report --include "coverage/**/*.json" on coverage.json report that I got from protractor-istanbul-plugin

/usr/local/lib/node_modules/istanbul/lib/report/html.js:239
                endCol = structuredText[startLine].text.originalLength();
                                                  ^

TypeError: Cannot read property 'text' of undefined
    at /usr/local/lib/node_modules/istanbul/lib/report/html.js:239:51
    at Array.forEach (native)
    at annotateFunctions (/usr/local/lib/node_modules/istanbul/lib/report/html.js:224:26)
    at HtmlReport.writeDetailPage (/usr/local/lib/node_modules/istanbul/lib/report/html.js:427:9)
    at /usr/local/lib/node_modules/istanbul/lib/report/html.js:489:26
    at AsyncFileWriter.processFile (/usr/local/lib/node_modules/istanbul/lib/util/file-writer.js:93:9)
    at /usr/local/lib/node_modules/istanbul/node_modules/async/lib/async.js:987:13
    at Immediate.process (/usr/local/lib/node_modules/istanbul/node_modules/async/lib/async.js:953:21)
    at runCallback (timers.js:637:20)
    at tryOnImmediate (timers.js:610:5)

In html report, in "File" cell link is broken if folder's/file's name has character that needs URI encoding
For example: src/app/+main/+dashboard/

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.523% when pulling 9a8f278 on treeskar:master into 89e338f on gotwarlost:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 96.628% when pulling 9a8f278 on treeskar:master into 89e338f on gotwarlost:master.

@kjackson87
Copy link

I'm seeing this error, definitely an annoying output error.

@Dustb0
Copy link

Dustb0 commented Dec 1, 2017

Are there any plans to merge this soon? :( This bug is really annoying

@johanneswilm
Copy link

@gotwarlost ping

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants