Skip to content

bug-fix: null check consumerRecord.value() before sending it to PB DynamicMessage.parseFrom #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajuGT merged 3 commits into from
Jan 29, 2026
Merged

bug-fix: null check consumerRecord.value() before sending it to PB DynamicMessage.parseFrom #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35e0016
bug-fix: null check consumerRecord.value() before sending it to PB Dy…
Nov 24, 2025
dc269b5
Fix test related to payload being null
Jan 29, 2026
1f1face
fix checkstyleTest
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ain/java/com/gotocompany/dagger/common/serde/proto/deserialization/ProtoDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,13 @@ public boolean isEndOfStream(Row nextElement) {
@Override
public Row deserialize(ConsumerRecord<byte[], byte[]> consumerRecord) {
Descriptors.Descriptor descriptor = getProtoParser();
byte[] value = consumerRecord.value();
if (value == null) {
LOGGER.warn("Record value / byteArray is NULL! " + protoClassName);
return createDefaultInvalidRow(DynamicMessage.getDefaultInstance(descriptor));
}
try {
DynamicMessage proto = DynamicMessage.parseFrom(descriptor, consumerRecord.value());
DynamicMessage proto = DynamicMessage.parseFrom(descriptor, value);
return addTimestampFieldToRow(proto);
} catch (DescriptorNotFoundException e) {
throw new DescriptorNotFoundException(e);
Expand Down
7 changes: 3 additions & 4 deletions ...java/com/gotocompany/dagger/common/serde/proto/deserialization/ProtoDeserializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import com.gotocompany.dagger.common.configuration.Configuration;
import com.gotocompany.dagger.common.core.StencilClientOrchestrator;
import com.gotocompany.dagger.common.exceptions.DescriptorNotFoundException;
import com.gotocompany.dagger.common.exceptions.serde.DaggerDeserializationException;
import com.gotocompany.dagger.common.serde.typehandler.RowFactory;
import com.gotocompany.dagger.consumer.*;
import org.apache.flink.api.common.typeinfo.TypeInformation;
Expand Down Expand Up @@ -246,10 +245,10 @@ public void shouldIgnoreStructWhileDeserialising() {
}

@Test
public void shouldThrowExceptionIfNotAbleToDeserialise() {
public void shouldMarkRecordInvalidIfThePayloadIsNull() {
ProtoDeserializer protoDeserializer = new ProtoDeserializer(TestNestedRepeatedMessage.class.getTypeName(), 6, "rowtime", stencilClientOrchestrator);
assertThrows(DaggerDeserializationException.class,
() -> protoDeserializer.deserialize(new ConsumerRecord<>("test-topic", 0, 0, null, null)));
Row row = protoDeserializer.deserialize(new ConsumerRecord<>("test-topic", 0, 0, null, null));
assertFalse((boolean) row.getField(row.getArity() - 2));
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions dagger-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ dependencies {
exclude group: "io.grpc"
}
dependenciesJar 'org.apache.flink:flink-connector-kafka_2.11:' + flinkVersion
dependenciesJar 'com.google.protobuf:protobuf-java:3.23.2'
dependenciesJar 'com.google.protobuf:protobuf-java-util:3.1.0'
dependenciesJar 'com.google.protobuf:protobuf-java:3.25.3'
dependenciesJar 'com.google.protobuf:protobuf-java-util:3.25.3'
dependenciesJar 'org.influxdb:influxdb-java:2.8'
dependenciesJar 'org.elasticsearch.client:elasticsearch-rest-client:6.6.1'
dependenciesJar 'com.google.cloud.bigtable:bigtable-hbase-2.x:2.10.0'
Expand Down