Skip to content

fix: remove unused runtime/cgo import that broke non-CGo builds#251

Open
tooolbox wants to merge 1 commit intogost-dom:mainfrom
tooolbox:fix/remove-unused-cgo-dependency
Open

fix: remove unused runtime/cgo import that broke non-CGo builds#251
tooolbox wants to merge 1 commit intogost-dom:mainfrom
tooolbox:fix/remove-unused-cgo-dependency

Conversation

@tooolbox
Copy link
Copy Markdown

@tooolbox tooolbox commented Mar 6, 2026

The handleDisposable type in scripting/internal/url/url.go was unused dead code that imported runtime/cgo, preventing sobekengine (and any package depending on scripting/internal/url) from compiling or testing without a C compiler.

The handleDisposable type in scripting/internal/url/url.go was unused
dead code that imported runtime/cgo, preventing sobekengine (and any
package depending on scripting/internal/url) from compiling or testing
without a C compiler.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a5ea5ef3-9b72-489f-98df-230e32770912

📥 Commits

Reviewing files that changed from the base of the PR and between 5fad72f and 6dda4ec.

📒 Files selected for processing (1)
  • scripting/internal/url/url.go
💤 Files with no reviewable changes (1)
  • scripting/internal/url/url.go

Walkthrough

This change removes internal implementation details from the URL package. Specifically, the non-exported type handleDisposable and its associated Dispose method have been removed, along with the runtime/cgo import. No public APIs are affected, and the overall functionality of the module remains unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing an unused runtime/cgo import that was breaking non-CGo builds. It is specific, concise, and directly reflects the changeset.
Description check ✅ Passed The description clearly explains the issue, the dead code being removed, and the impact on non-CGo builds. It is directly related to the changeset and provides relevant context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant