fix: remove unused runtime/cgo import that broke non-CGo builds#251
fix: remove unused runtime/cgo import that broke non-CGo builds#251tooolbox wants to merge 1 commit intogost-dom:mainfrom
Conversation
The handleDisposable type in scripting/internal/url/url.go was unused dead code that imported runtime/cgo, preventing sobekengine (and any package depending on scripting/internal/url) from compiling or testing without a C compiler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThis change removes internal implementation details from the URL package. Specifically, the non-exported type 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The handleDisposable type in scripting/internal/url/url.go was unused dead code that imported runtime/cgo, preventing sobekengine (and any package depending on scripting/internal/url) from compiling or testing without a C compiler.