Skip to content

feat: Add support for the parent expression and fix integration tests error#2351

Merged
yvonnep165 merged 5 commits intomainfrom
yvonne/parent-expression
Mar 30, 2026
Merged

feat: Add support for the parent expression and fix integration tests error#2351
yvonnep165 merged 5 commits intomainfrom
yvonne/parent-expression

Conversation

@yvonnep165
Copy link
Copy Markdown
Contributor

@yvonnep165 yvonnep165 commented Mar 30, 2026

  • Add support for the parent expression

Ported from firebase/firebase-js-sdk#9773

  • Change integration tests testPipelineInTransactions and testNestedFields due to the changes of nested field handling by backend
  • Change integration test testChecks due to change in backend implementation - treat applying an array operation to a non-array field as a strict evaluation error. Therefore, isError() now returns true, and ifError() triggers, returning fallback handler
  • Change PipelineUtils.java where it automatically generated aliases with dots for nested fields, to fix error for test performsAggregationsOnNestedMapValues in ITQueryAggregationsTest.java

@yvonnep165 yvonnep165 requested review from dlarocque and milaGGL March 30, 2026 16:02
@yvonnep165 yvonnep165 requested a review from a team as a code owner March 30, 2026 16:02
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Mar 30, 2026
@yvonnep165 yvonnep165 changed the title feat: Add support for the parent expression feat: Add support for the parent expression and fix integration tests error Mar 30, 2026
@yvonnep165 yvonnep165 requested a review from wu-hui March 30, 2026 19:52
@yvonnep165 yvonnep165 merged commit 0e30ec4 into main Mar 30, 2026
28 checks passed
@yvonnep165 yvonnep165 deleted the yvonne/parent-expression branch March 30, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants