cleanup(gax-internal): macros use literal attribute names#5209
Merged
coryan merged 2 commits intogoogleapis:mainfrom Mar 31, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5209 +/- ##
==========================================
- Coverage 98.02% 98.01% -0.01%
==========================================
Files 214 214
Lines 44218 44250 +32
==========================================
+ Hits 43344 43371 +27
- Misses 874 879 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5b206d8 to
5430c37
Compare
By using the literal attribute names we can reduce the number of constants exported by `google-cloud-gax-internal`. And therefore reduce the number of future breaking changes.
5430c37 to
237ec03
Compare
westarle
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using the literal attribute names we can reduce the number of constants exported by
google-cloud-gax-internal. And therefore reduce the number of future breaking changes.Part of the work for #4772