Skip to content

cleanup(gax-internal): macros use literal attribute names#5209

Merged
coryan merged 2 commits intogoogleapis:mainfrom
coryan:cleanup-gax-internal-macros-do-not-use-attribute-names
Mar 31, 2026
Merged

cleanup(gax-internal): macros use literal attribute names#5209
coryan merged 2 commits intogoogleapis:mainfrom
coryan:cleanup-gax-internal-macros-do-not-use-attribute-names

Conversation

@coryan
Copy link
Copy Markdown
Collaborator

@coryan coryan commented Mar 30, 2026

By using the literal attribute names we can reduce the number of constants exported by google-cloud-gax-internal. And therefore reduce the number of future breaking changes.

Part of the work for #4772

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.01%. Comparing base (388da11) to head (02f5eaf).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...c/observability/client_signals/with_client_span.rs 93.75% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5209      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         214      214              
  Lines       44218    44250      +32     
==========================================
+ Hits        43344    43371      +27     
- Misses        874      879       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan force-pushed the cleanup-gax-internal-macros-do-not-use-attribute-names branch 3 times, most recently from 5b206d8 to 5430c37 Compare March 31, 2026 11:31
By using the literal attribute names we can reduce the number of constants
exported by `google-cloud-gax-internal`. And therefore reduce the number of
future breaking changes.
@coryan coryan force-pushed the cleanup-gax-internal-macros-do-not-use-attribute-names branch from 5430c37 to 237ec03 Compare March 31, 2026 14:05
@coryan coryan marked this pull request as ready for review March 31, 2026 14:33
@coryan coryan requested a review from a team as a code owner March 31, 2026 14:33
@coryan coryan enabled auto-merge (squash) March 31, 2026 16:10
@coryan coryan merged commit fb9fd69 into googleapis:main Mar 31, 2026
36 checks passed
@coryan coryan deleted the cleanup-gax-internal-macros-do-not-use-attribute-names branch March 31, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants