Skip to content

[zerocopy] Re-enable big endian aarch64 types#3073

Merged
joshlf merged 1 commit intogoogle:mainfrom
197g:main
Mar 28, 2026
Merged

[zerocopy] Re-enable big endian aarch64 types#3073
joshlf merged 1 commit intogoogle:mainfrom
197g:main

Conversation

@197g
Copy link
Copy Markdown
Contributor

@197g 197g commented Feb 27, 2026

When initially released the LLVM semantics did not agree with the intrinsics in the order of lanes and hence they got removed from stable on big endian targets. The fix of these semantics was shipped with Rust 1.87 in March 2025 (rust-lang/rust#136831).

To keep the library working in these previous compiler versions the intrinsics are enabled by their prior condition, a little endian target is detected, or the feature detection cfg of the more recent rust release is present.

Interesting point: the tests were never gated on target_endian = "little" so it seems that CI is not configured for any big endian aarch64 platform.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@google-cla
Copy link
Copy Markdown

google-cla bot commented Feb 27, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (61b2407) to head (e84b8d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3073   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6067     6067           
=======================================
  Hits         5573     5573           
  Misses        494      494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@197g
Copy link
Copy Markdown
Contributor Author

197g commented Feb 27, 2026

I don't know what it wants me to change in the CI file. Adding the new flag to the matrix is straightforward but the jobs/build_test/matrix/exclude section is odd. I suppose it should copy whatever is defined for no-zerocopy-aarch64-simd-1-59-0?

Copy link
Copy Markdown
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and sorry for the late reply! Looks great, just a few small nits.

@197g 197g force-pushed the main branch 2 times, most recently from 21e0177 to 70809e8 Compare March 21, 2026 13:58
When initially released the LLVM semantics did not agree with the
intrinsics in the order of lanes and hence they got removed from stable
on big endian targets. The fix of these semantics was shipped with Rust
1.87 in March 2025 (<rust-lang/rust#136831>).

To keep the library working in these previous compiler versions the
intrinsics are enabled by their prior condition, a little endian target
is detected, or the feature detection cfg of the more recent rust
release is present.

Co-Authored-By: Jack Wrenn <jswrenn@google.com>
@joshlf joshlf dismissed jswrenn’s stale review March 28, 2026 20:38

Addressed.

@joshlf joshlf added this pull request to the merge queue Mar 28, 2026
Merged via the queue into google:main with commit fa6fa90 Mar 28, 2026
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants