Skip to content

Thread-safety for building global environment#89

Merged
wdhongtw merged 1 commit intomainfrom
init-safety
Apr 10, 2026
Merged

Thread-safety for building global environment#89
wdhongtw merged 1 commit intomainfrom
init-safety

Conversation

@wdhongtw
Copy link
Copy Markdown
Collaborator

@wdhongtw wdhongtw commented Apr 8, 2026

Ensure multi-thread program don't break when all threads are calling default_env on themselves.

Document and adjust public interface. Fixing some broken test.

Signed-off-by: Weida Hong <wdhongtw@google.com>
@wdhongtw wdhongtw requested review from kyuyeunk and qihqi April 8, 2026 17:31
@wdhongtw
Copy link
Copy Markdown
Collaborator Author

wdhongtw commented Apr 8, 2026

CC Kyuyeun here because I remember an attempt to parallelize model pre-compile in vLLM-TPU someday before.

Feel free to ignore this review request if there is no resource on this.

@wdhongtw wdhongtw merged commit 8f957d1 into main Apr 10, 2026
5 checks passed
@wdhongtw wdhongtw deleted the init-safety branch April 10, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants