Conversation
1. Add a new GetRecordFileName method, prefers the test name from header if present 2. Add magic words used to split websocket client and server message chunks See example replay file: https://gist.github.com/hkt74/2430f265644dc5d5b62a7fd7ad97f1a6
1. Add a new GetRecordFileName method, prefers the test name from header if present 2. Add magic words used to split websocket client and server message chunks See example replay file: https://gist.github.com/hkt74/2430f265644dc5d5b62a7fd7ad97f1a6
amirh
requested changes
Jun 25, 2025
amirh
requested changes
Jun 25, 2025
| recChunk := string(runes[1:]) | ||
| if reqChunk != recChunk { | ||
| fmt.Printf("input chunk mismatch\n Input chunk: %s\n Recorded chunk: %s\n", reqChunk, recChunk) | ||
| return |
Collaborator
There was a problem hiding this comment.
Do we need to return an error in this case? how would we know to fail the test?
Collaborator
Author
There was a problem hiding this comment.
Good call, the current behavior test will fail after timeout (5 seconds), the test is awaiting message from the server, while the request mismatch would skip the subsequent message write
To make it fail fast, we probably could write an error message in the session, but it require the test setup to listen to the error message and fail the test.
what do you think I track this as a follow up action? need more time to explore the possible jasmine setup.
Collaborator
There was a problem hiding this comment.
Is it possible to close the connection with an error?
amirh
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.