Add optional annotations to some Result fields for memory actions.#204
Add optional annotations to some Result fields for memory actions.#204CRefice wants to merge 1 commit intogoogle:masterfrom
Conversation
This makes field presence behave as expected.
|
Could you expand by what you mean by "behave as expected"? In general, I am not fan of |
|
Right, should have expanded. The problem I have is that many of those fields are, quoting the comments, |
We are using
Do we have a specific use case for using additional field presence of these specific fields? For me using it is a backward compatibility footgun. Otherwise you could argue that you should always just include |
|
Fair enough. I had some use cases in mind, but as I've been writing and rewriting the server-side flow I realized they were unnecessary. I'll close this PR for now. |
This makes field presence behave as expected.