feat(wish): make it able to run both TLS and non-TLS benchmark#29
Merged
feat(wish): make it able to run both TLS and non-TLS benchmark#29
Conversation
tyoshino
commented
Mar 23, 2026
| check=True, | ||
| ) | ||
|
|
||
| if certs_dir: |
Collaborator
Author
There was a problem hiding this comment.
need to send certs, too
Comment on lines
+29
to
+32
| ABSL_FLAG(std::string, ca_cert, "certs/ca.crt", "Path to CA certificate"); | ||
| ABSL_FLAG(std::string, client_cert, "certs/client.crt", | ||
| "Path to client certificate"); | ||
| ABSL_FLAG(std::string, client_key, "../certs/client.key", | ||
| ABSL_FLAG(std::string, client_key, "certs/client.key", |
Collaborator
Author
There was a problem hiding this comment.
adjusting the default path
Comment on lines
+104
to
+107
| int result = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &nodelay, sizeof(nodelay)); | ||
| if (result != 0) { | ||
| LOG(FATAL) << "setsockopt(TCP_NODELAY) failed"; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
added return value check using this opportunity
|
|
||
| if (!server.Init()) { | ||
| std::cerr << "Failed to initialize server" << std::endl; | ||
| LOG(ERROR) << "Failed to initialize server"; |
Collaborator
Author
There was a problem hiding this comment.
switched to abseil logging library using this opportunity
Comment on lines
+4
to
+7
| #include <netinet/tcp.h> | ||
|
|
||
| #include <cstring> | ||
| #include <iostream> |
Collaborator
Author
There was a problem hiding this comment.
automated reordering to comply with the Google C++ Style Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.