fix(http2): make the benchmark disable Nagle's algorithm#22
Merged
Conversation
tyoshino
commented
Mar 17, 2026
| struct event_base* evbase; | ||
|
|
||
| int requests_completed; | ||
| int requests_in_flight; |
| int requests_completed; | ||
| int requests_in_flight; | ||
| int total_requests_submitted; | ||
| struct timeval start_time; |
| client->request_start_times.erase(it); | ||
| } | ||
|
|
||
| int loopexit_result = event_base_loopexit(client->evbase, NULL); |
Collaborator
Author
There was a problem hiding this comment.
adding return value checking for ones that may fail with an error
| } | ||
|
|
||
| // nghttp2 callbacks | ||
| static void setup_nghttp2_callbacks(nghttp2_session_callbacks* callbacks) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and bunch of clean up.