feat(http2): add a simple benchmark of HTTP2 using libevents and nghttp2#20
Merged
feat(http2): add a simple benchmark of HTTP2 using libevents and nghttp2#20
Conversation
tyoshino
commented
Mar 4, 2026
| int report_interval = absl::GetFlag(FLAGS_report_interval); | ||
| if (report_interval > 0 && client->requests_completed % report_interval == 0) { | ||
| struct timeval now; | ||
| gettimeofday(&now, NULL); |
Collaborator
Author
There was a problem hiding this comment.
I'll change this to chrono later
| // Send connection preface and initial settings | ||
| nghttp2_settings_entry iv[2] = { | ||
| {NGHTTP2_SETTINGS_MAX_CONCURRENT_STREAMS, static_cast<uint32_t>(absl::GetFlag(FLAGS_concurrent_requests))}, | ||
| {NGHTTP2_SETTINGS_INITIAL_WINDOW_SIZE, 128 * 1024 * 1024}}; |
Collaborator
Author
There was a problem hiding this comment.
More study on window size needed to conduct the right benchmark and comparison with gRPC one (chttp2 and BDP behavior)
tyoshino
changed the title
tyoshino
changed the title
tyoshino
commented
Mar 9, 2026
http2/.gitignore
Outdated
| Makefile | ||
|
|
||
| build | ||
| _deps |
Collaborator
Author
There was a problem hiding this comment.
added by mistake. removed
Collaborator
Author
|
ready for review again |
Collaborator
Author
|
I'll update it to use https://github.com/google/benchmark by a separate PR. |
wenbozhu
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.