Add calculations for YUV / planar images#479
Open
anishmgoyal wants to merge 5 commits intogoogle:mainfrom
Open
Add calculations for YUV / planar images#479anishmgoyal wants to merge 5 commits intogoogle:mainfrom
anishmgoyal wants to merge 5 commits intogoogle:mainfrom
Conversation
anishmgoyal
commented
Jun 6, 2024
anishmgoyal
force-pushed
the
addYUVPlanarCalculations
branch
2 times, most recently
from
8e74f39 to
4bce41e
Compare
anishmgoyal
commented
Jun 6, 2024
apazylbe
requested changes
Jun 7, 2024
anishmgoyal
force-pushed
the
addYUVPlanarCalculations
branch
from
4bce41e to
c9ed717
Compare
anishmgoyal
force-pushed
the
addYUVPlanarCalculations
branch
from
2aa3d29 to
71f2228
Compare
Keenuts
reviewed
Jun 10, 2024
anishmgoyal
force-pushed
the
addYUVPlanarCalculations
branch
from
e14a6a3 to
e588acf
Compare
Also, create format definitions for YUV images.
Put self-header at the top, and C++ std headers after, before project- wide headers.
anishmgoyal
force-pushed
the
addYUVPlanarCalculations
branch
from
279d8a5 to
9f6e6a6
Compare
Keenuts
reviewed
Jun 11, 2024
Keenuts
reviewed
Jun 11, 2024
Keenuts
reviewed
Jun 11, 2024
Add a quick explanation of what chroma subsampling is / how it affects how pixels are stored.
Keenuts
approved these changes
Jun 13, 2024
wangra-google
approved these changes
Jun 13, 2024
apazylbe
reviewed
Jun 14, 2024
| // Splits the frames from a raw video, based on the format of the frames, | ||
| // and metadata such as height and width. This assumes raw video, with no | ||
| // metadata in the file itself, and no audio tracks (such as a camera | ||
| // feed). Returns if the operation succeeded. |
Collaborator
There was a problem hiding this comment.
"Returns if the operation succeeded"? Did you mean to say "Returns X", cause couldn't it return error code as well?
| std::vector<char> buffer(frameSize); | ||
| size_t totalRead = 0; | ||
| while (totalRead < fileSize) { | ||
| const size_t bytesRead = file.Read(buffer.data(), frameSize); |
Collaborator
There was a problem hiding this comment.
Is this safe to do after a std::move operation? Would buffer have frameSize capacity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, create format definitions for YUV images.