feat(cli): change default loadingPhrases to 'off' to hide tips#24342
feat(cli): change default loadingPhrases to 'off' to hide tips#24342keithguerin merged 3 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the default user interface experience for the CLI by switching the type of loading messages displayed. Instead of showing helpful tips by default, the system will now present witty comments. Users retain the flexibility to configure their preference to show tips, both, or neither, ensuring a customizable experience while providing a fresh default interaction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default value for the ui.loadingPhrases configuration setting from "tips" to "witty". These changes are consistently applied across the documentation, the settings schema, and the unit tests. I have no feedback to provide.
keithguerin
force-pushed
the
change-loading-phrases-default
branch
from
a7c577b to
d1bf66f
Compare
keithguerin
changed the title
|
Size Change: -10 B (0%) Total Size: 34.6 MB
ℹ️ View Unchanged
|
| | Default Approval Mode | `general.defaultApprovalMode` | The default approval mode for tool execution. 'default' prompts for approval, 'auto_edit' auto-approves edit tools, and 'plan' is read-only mode. YOLO mode (auto-approve all actions) can only be enabled via command line (--yolo or --approval-mode=yolo). | `"default"` | | ||
| | Enable Auto Update | `general.enableAutoUpdate` | Enable automatic updates. | `true` | | ||
| | Enable Notifications | `general.enableNotifications` | Enable run-event notifications for action-required prompts and session completion. | `false` | | ||
| | Enable Plan Mode | `general.plan.enabled` | Enable Plan Mode for read-only safety during planning. | `true` | |
There was a problem hiding this comment.
is this an intentional change?
There was a problem hiding this comment.
Done. This was an unintentional regression from a merge conflict resolution. I have restored the 'general.plan.enabled' row.
docs/cli/settings.md
Outdated
| | Enable Git Worktrees | `experimental.worktrees` | Enable automated Git worktree management for parallel work. | `false` | | ||
| | Use OSC 52 Paste | `experimental.useOSC52Paste` | Use OSC 52 for pasting. This may be more robust than the default system when using remote terminal sessions (if your terminal is configured to allow it). | `false` | | ||
| | Use OSC 52 Copy | `experimental.useOSC52Copy` | Use OSC 52 for copying. This may be more robust than the default system when using remote terminal sessions (if your terminal is configured to allow it). | `false` | | ||
| | Plan | `experimental.plan` | Enable Plan Mode. | `true` | |
There was a problem hiding this comment.
looks like another unintentional change?
likely that resolving merge conflicts went wrong
There was a problem hiding this comment.
Done. I have removed the obsolete 'experimental.plan' row.
gemini-cli
bot
added
the
status/need-issue
keithguerin
force-pushed
the
change-loading-phrases-default
branch
from
dc41ce3 to
9c94feb
Compare
keithguerin
force-pushed
the
change-loading-phrases-default
branch
from
a886965 to
d6457b6
Compare
keithguerin
force-pushed
the
change-loading-phrases-default
branch
from
d6457b6 to
4be01c9
Compare
|
/patch preview |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ [Step 4/4] Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
4 participants
Summary
This PR changes the default value of
ui.loadingPhrasesfrom'tips'to'off'.Details
packages/cli/src/config/settingsSchema.tsto change the default value to'off'and updated the description to match enum values.schemas/settings.schema.jsonto reflect the new default and updated description.docs/cli/settings.mdanddocs/reference/configuration.md.general.plan.enabledand removedexperimental.planindocs/cli/settings.mdto match the current state ofmain.packages/cli/src/config/settingsSchema.test.tsto assert the new default value.This change ensures that helpful tips are no longer shown by default during model loading. Users can still opt-in to tips by setting
ui.loadingPhrasesto'tips'or'all'in their configuration.