feat(plan): promote planning feature to stable#24282
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes the planning feature to a stable, core configuration setting. It updates the configuration schema, documentation, and testing infrastructure to reflect this change while ensuring backward compatibility for existing users through an automated migration process. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the plan mode setting from experimental.plan to general.plan.enabled across the documentation, configuration schemas, and test suites. It also includes a migration function to handle existing user settings. One issue was identified in evals/plan_mode.eval.ts where a typo in the property name (enable instead of enabled) would cause the setting to be ignored.
|
Size Change: +693 B (0%) Total Size: 26.5 MB
ℹ️ View Unchanged
|
ruomengz
force-pushed
the
feat/24263-remove-plan-experimental
branch
from
84fb7e3 to
d3dad96
Compare
gemini-cli
bot
added
area/core
ruomengz
force-pushed
the
feat/24263-remove-plan-experimental
branch
2 times, most recently
from
0f177e3 to
9312285
Compare
ruomengz
force-pushed
the
feat/24263-remove-plan-experimental
branch
2 times, most recently
from
dde3ddd to
b95c2b3
Compare
- Move planning configuration from experimental.plan to general.plan.enable - Update settings schema and documentation - Maintain backward compatibility for experimental.plan - Improve migrateExperimental helper to handle falsy values fixes #24263
ruomengz
force-pushed
the
feat/24263-remove-plan-experimental
branch
from
b95c2b3 to
837189e
Compare
ruomengz
force-pushed
the
feat/24263-remove-plan-experimental
branch
from
837189e to
3e64139
Compare
|
/patch preview |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
# Conflicts: # docs/cli/settings.md
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
turns out preview release has not been cut yet, so just stopping this patch |
2 participants
Summary
This PR graduates the "planning" feature from experimental status to a core configuration setting, as tracked in #24263.
Details
experimental.plantogeneral.plan.enabled.migrateExperimentalSettingsto automatically transition existing user configurations while maintaining backward compatibility.migrateExperimentalhelper to correctly handle falsy values during migration.Related Issues
Fixes #24263
How to Validate
general.plan.enabled: true(or false) insettings.jsonand verify the CLI respects the setting.experimental.plan: trueand verify it is migrated to the new path upon startup.npm test -w @google/gemini-cliand verify configuration-related tests pass.Pre-Merge Checklist