revert: chore(config): disable agents by default#23672
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change, restoring the default behavior of enabling agents. It ensures that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -6 B (0%) Total Size: 26.2 MB
ℹ️ View Unchanged
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the default value of the experimental.enableAgents setting from false to true across documentation, JSON schemas, and various configuration loading and test files. Additionally, it exports PRIORITY_YOLO_ALLOW_ALL from the core policy types and uses it in a test mock. The review comments highlight a potential redundancy in the nullish coalescing operators (?? true) for enableAgents in packages/a2a-server/src/config/config.ts and packages/core/src/config/config.ts. This redundancy might indicate an inconsistency in how configuration parameters are constructed or how schema defaults are applied, given the rule to rely on the schema as the single source of truth for defaults.
gemini-cli
bot
added
the
status/need-issue
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/patch preview |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 [Step 3/4] Patch Release Waiting for Approval! 📋 Release Details:
⏳ Status: The patch release has been triggered and is waiting for deployment approval. Please visit the specific workflow run link below and approve the deployment. You'll receive another update when it completes. 🔗 Track Progress: |
|
❌ [Step 4/4] Patch Release Failed! 📋 Details:
🔍 Next Steps:
🔗 Troubleshooting: |
2 participants
Summary
Reverts commit
557fffe1f3f9cf5500decba949efb1483815fa60to restore theenableAgentsdefault totrue.Details
cli,core, anda2a-server.true.PRIORITY_YOLO_ALLOW_ALLincore/src/index.tsand fixed the corresponding mock ina2a-servertests to resolve test/lint blockers.Related Issues
How to Validate
Targeted tests pass: