fix(patch): cherry-pick 8432bce to release/v0.33.0-pr-22069 to patch version v0.33.0 and create version 0.33.1#22206
Conversation
…rds in subagents (#22069)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines tool management within the system by introducing support for wildcard tool names and standardizing the naming convention for Micro-Component Platform (MCP) tools. These changes simplify how agents declare and register tools, improving flexibility and consistency in tool discovery and usage. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a commit to support wildcard tool definitions in agents and to standardize the naming convention for MCP (Model Context Protocol) tools. The changes are well-implemented across agent loading, execution, and tool registration. The new MCP tool name format (mcp_server_tool) is consistently applied and validated. The logic for expanding wildcard tool definitions (*, mcp_*, mcp_server_*) is correctly handled in the LocalAgentExecutor. The removal of the asFullyQualifiedTool method simplifies the handling of MCP tools, and the necessary adjustments in the tool registry ensure that correct, fully-qualified tool names are used in schemas sent to the model. The accompanying test updates properly cover the new functionality and format changes. Overall, the changes are robust and I have no further feedback.
|
Size Change: +170 B (0%) Total Size: 25.6 MB ℹ️ View Unchanged
|
This commit fixes an issue where LocalAgentExecutor would push the schema of an instantiated tool twice during agent invocation, leading to 'Duplicate function declaration' API errors.
This PR automatically cherry-picks commit 8432bce to patch version v0.33.0 in the stable release to create version 0.33.1.