fix(patch): cherry-pick 3ff68a9 to release/v0.33.0-preview.14-pr-21884 [CONFLICTS]#21940
Conversation
# Conflicts: # package-lock.json # packages/core/package.json
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated cherry-pick operation aimed at incorporating a critical fix related to a Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix for a stream corruption bug in gaxios by downgrading @google/genai and google-auth-library dependencies and adding a CI check to prevent accidental upgrades. However, there is a critical unresolved merge conflict in packages/core/package.json that must be fixed. Additionally, the new CI check in scripts/check-lockfile.js contains logic that may not correctly guard against all problematic versions of gaxios.
Note: Security Review is unavailable for this PR.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/core/package.json (28-33)
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). These markers must be removed and the conflict must be resolved by choosing the correct version of the dependencies. Based on the other changes in this PR, it seems the intention is to downgrade @google/genai to 1.30.0 and add @grpc/grpc-js.
Please replace the conflicted block with:
"@google/genai": "1.30.0",
"@grpc/grpc-js": "^1.14.3",scripts/check-lockfile.js (83)
The condition !location.includes('@google/genai/node_modules') seems to weaken the safeguard against gaxios@7+. If a problematic version of gaxios is installed but nested inside @google/genai/node_modules, this check would ignore it. Given that the gaxios issue is related to dependencies of @google/genai, it seems this check should apply to all instances of gaxios in the lockfile to be fully effective. Consider removing this part of the condition to ensure no version of gaxios@7+ is present anywhere in the dependency tree.
This PR automatically cherry-picks commit 3ff68a9 to patch version v0.33.0-preview.14 in the preview release to create version 0.33.0-preview.15.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: