fix(patch): cherry-pick 5dd2dab to release/v0.33.0-preview.11-pr-21871#21876
Conversation
…ation phase (#21871) # Conflicts: # packages/core/src/availability/policyHelpers.ts
|
Size Change: +872 B (0%) Total Size: 25.9 MB ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the model routing strategies within the application, particularly concerning the automatic model selection and the integration of Gemini 3.1 features. The changes ensure that the correct models are selected based on the configuration, approval mode, and the availability of Gemini 3.1, including custom tool models. The updates also include new test cases to validate the routing logic. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick that introduces several refactorings, such as encapsulating logic for determining model usage into new methods on the Config class. However, a critical issue was found in packages/core/src/availability/policyHelpers.ts where merge conflict markers were left in the code. This will break the build and must be fixed. The other changes appear to be correct refactorings and test updates to support the new logic.
Note: Security Review did not run due to the size of the PR.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/core/src/availability/policyHelpers.ts (48-55)
This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>), which will cause syntax errors and prevent the code from compiling. It appears the merge conflict was not resolved correctly.
Specifically:
- The variable
useCustomToolModelis declared twice within the conflict block. - The variable
hasAccessToPreviewis declared inside the conflict block and again on line 64. - The
AuthTypeimport was removed, making the code in theHEADportion of the conflict invalid.
Please resolve the conflict by removing the markers and duplicate declarations.
const useCustomToolModel = config.getUseCustomToolModelSync?.() ?? false;
This PR automatically cherry-picks commit 5dd2dab to patch version v0.33.0-preview.11 in the preview release to create version 0.33.0-preview.12.
✅ Merge Conflicts Resolved
The merge conflicts resulting from this cherry-pick have been successfully resolved.
🚨 Important: