fix(patch): cherry-pick 35ee2a8 to release/v0.33.0-preview.10-pr-21713#21859
Conversation
# Conflicts: # docs/cli/plan-mode.md # packages/core/src/config/config.ts
…/cli/plan-mode.md
|
Size Change: -34 B (0%) Total Size: 25.9 MB ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a commit to enable Plan Mode by default in the Gemini CLI. This change simplifies the user experience by removing the need to manually enable Plan Mode. The documentation and configuration have been updated to reflect this change. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request changes the default state of "Plan Mode" from disabled to enabled, updating its description across documentation, configuration schemas, and test files. A critical issue was identified in packages/core/src/config/config.ts where an unresolved merge conflict exists, preventing the correct default enablement of planEnabled and introducing an unrelated trackerEnabled property, which needs to be resolved.
Note: Security Review did not run due to the size of the PR.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/core/src/config/config.ts (872-877)
This file contains unresolved merge conflict markers. Based on the pull request description, it seems the intention was to enable planEnabled by default and omit trackerEnabled. Please resolve the conflict.
this.planEnabled = params.plan ?? true;
This PR automatically cherry-picks commit 35ee2a8 to patch version v0.33.0-preview.10 in the preview release to create version 0.33.0-preview.11.
Conflicts have been manually resolved:
trackerEnabledproperty from the cherry-picked commit was omitted as it does not exist in this release branch.