Open
Conversation
hartikainen
commented
Sep 7, 2025
Comment on lines
-259
to
+264
| data = text_format.MessageToBytes(job) | ||
| data = text_format.MessageToString(job) |
Author
There was a problem hiding this comment.
This seemed like a bug to me. The database column for job_data is of type sa.String(255), so I think the data should be formatted as string and not bytes. MessageToString is also in line with what insert_kubernetes_job below does already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60. The tests were created with
gemini-cli's help.Also fixes what I believe could be a big in how the job data is handled. See my comment in-line.