Open
Conversation
hartikainen
commented
Jul 7, 2025
| visited.add(current) | ||
| ns = named_sets.get(current) | ||
| if ns: | ||
| outputs.extend(ns.files) |
Author
There was a problem hiding this comment.
I noticed that ns.files resulting from py_binary targets may contain more than one output: one for the binary and more than zero for the source code. This messes up the downstream usages which check len(paths) == 1. See e.g. here:
xmanager/xmanager/xm_local/packaging/local.py
Line 137 in 7a9cfd0
I think we only care for the binary and should probably filter out the source files.
Author
There was a problem hiding this comment.
See 19c62cd. My bazel-foo is a little weak and I don't know what the right way to handle this is. But I've verified not that it works for raw py_binary targets and also oci_load container image targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.