Skip to content

Refactoring_CodeReview#63

Open
VolodarF13 wants to merge 2 commits intogoitProjects:mainfrom
VolodarF13:main
Open

Refactoring_CodeReview#63
VolodarF13 wants to merge 2 commits intogoitProjects:mainfrom
VolodarF13:main

Conversation

@VolodarF13
Copy link
Copy Markdown

No description provided.

System.out.println("-----------");
System.out.println(" " + BOX[6] + " | " + BOX[7] + " | " + BOX[8] + " \n");
}
} No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed empty line in the end of file

};

return Stream.of(winPattern)
.anyMatch(pattern ->
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should looks like this

       .anyMatch(pattern -> BOX[pattern[0]] == player 
                && BOX[pattern[1]] == player 
                && BOX[pattern[2]] == player);

while (true) {
input = SCANNER.nextByte();
if (input > 0 && input < 10) {
if (BOX[input - 1] == 'X' || BOX[input - 1] == 'O')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed {

boolean boxAvailable = false;
byte i;
for(i=0; i<9; i++){
if(BOX[i] != 'X' && BOX[i] != 'O'){
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate braces by space ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants