Skip to content

code refactoring #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purpledonutoil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

code refactoring #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 95 additions & 67 deletions src/main/java/App.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,90 +1,118 @@
import java.util.Scanner;

public class App {
private char[] box = { '1', '2', '3', '4', '5', '6', '7', '8', '9' };
private boolean boxAvailable = false;
private boolean boxEmpty = false;

public static void main(String[] args) {
Scanner scan = new Scanner(System.in);
byte input;
byte rand;
byte i;
boolean boxAvailable = false;
byte winner = 0;
char box[] = { '1', '2', '3', '4', '5', '6', '7', '8', '9' };
System.out.println("Enter box number to select. Enjoy!\n");
App app = new App();
app.startGame();
}

boolean boxEmpty = false;
while (true) {
System.out.println("\n\n " + box[0] + " | " + box[1] + " | " + box[2] + " ");
System.out.println("-----------");
System.out.println(" " + box[3] + " | " + box[4] + " | " + box[5] + " ");
System.out.println("-----------");
System.out.println(" " + box[6] + " | " + box[7] + " | " + box[8] + " \n");
if(!boxEmpty){
for(i = 0; i < 9; i++)
box[i] = ' ';
boxEmpty = true;
}
public void printBox(){
System.out.println("\n\n " + box[0] + " | " + box[1] + " | " + box[2] + " " +
"\n-----------\n "
+ box[3] + " | " + box[4] + " | " + box[5] + " " +
"\n-----------\n" +
" " + box[6] + " | " + box[7] + " | " + box[8] + " \n");
}

if(winner == 1){
System.out.println("You won the game!\nCreated by Shreyas Saha. Thanks for playing!");
break;
} else if(winner == 2){
System.out.println("You lost the game!\nCreated by Shreyas Saha. Thanks for playing!");
break;
} else if(winner == 3){
System.out.println("It's a draw!\nCreated by Shreyas Saha. Thanks for playing!");
public void checkBoxAvalability(){
boxAvailable = false;
for(int i=0; i<9; i++){
if(box[i] != 'X' && box[i] != 'O'){
boxAvailable = true;
break;
}
}
}

while (true) {
input = scan.nextByte();
if (input > 0 && input < 10) {
if (box[input - 1] == 'X' || box[input - 1] == 'O')
System.out.println("That one is already in use. Enter another.");
else {
box[input - 1] = 'X';
break;
}
}
else
System.out.println("Invalid input. Enter again.");
}
public void setBoxEmpty(){
if(!boxEmpty){
for(int i = 0; i < 9; i++)
box[i] = ' ';
boxEmpty = true;
}
}

if((box[0]=='X' && box[1]=='X' && box[2]=='X') || (box[3]=='X' && box[4]=='X' && box[5]=='X') || (box[6]=='X' && box[7]=='X' && box[8]=='X') ||
(box[0]=='X' && box[3]=='X' && box[6]=='X') || (box[1]=='X' && box[4]=='X' && box[7]=='X') || (box[2]=='X' && box[5]=='X' && box[8]=='X') ||
(box[0]=='X' && box[4]=='X' && box[8]=='X') || (box[2]=='X' && box[4]=='X' && box[6]=='X')){
winner = 1;
continue;
public void player2(){
byte rand;
while (true) {
rand = (byte) (Math.random() * (9 - 1 + 1) + 1);
if (box[rand - 1] != 'X' && box[rand - 1] != 'O') {
box[rand - 1] = 'O';
break;
}
}
}

boxAvailable = false;
for(i=0; i<9; i++){
if(box[i] != 'X' && box[i] != 'O'){
boxAvailable = true;
public void player1(Scanner scan){
byte input;
while (true) {
input = scan.nextByte();
if (input > 0 && input < 10) {
if (box[input - 1] == 'X' || box[input - 1] == 'O')
System.out.println("That one is already in use. Enter another.");
else {
box[input - 1] = 'X';
break;
}
}
else
System.out.println("Invalid input. Enter again.");
}
}

if(boxAvailable == false){
winner = 3;
continue;
}
public boolean winningCombination(char c){
return (box[0]==c && box[1]==c && box[2]==c) || (box[3]==c && box[4]==c && box[5]==c) || (box[6]==c && box[7]==c && box[8]==c) ||
(box[0]==c && box[3]==c && box[6]==c) || (box[1]==c && box[4]==c && box[7]==c) || (box[2]==c && box[5]==c && box[8]==c) ||
(box[0]==c && box[4]==c && box[8]==c) || (box[2]==c && box[4]==c && box[6]==c);
}

while (true) {
rand = (byte) (Math.random() * (9 - 1 + 1) + 1);
if (box[rand - 1] != 'X' && box[rand - 1] != 'O') {
box[rand - 1] = 'O';
break;
}
}
public boolean checkWinner1(){
if(winningCombination('X')){
printBox();
System.out.println("You won the game!\nCreated by Shreyas Saha. Thanks for playing!");
return true;
}
return false;
}

if((box[0]=='O' && box[1]=='O' && box[2]=='O') || (box[3]=='O' && box[4]=='O' && box[5]=='O') || (box[6]=='O' && box[7]=='O' && box[8]=='O') ||
(box[0]=='O' && box[3]=='O' && box[6]=='O') || (box[1]=='O' && box[4]=='O' && box[7]=='O') || (box[2]=='O' && box[5]=='O' && box[8]=='O') ||
(box[0]=='O' && box[4]=='O' && box[8]=='O') || (box[2]=='O' && box[4]=='O' && box[6]=='O')){
winner = 2;
continue;
}
public boolean checkWinner2(){
if(winningCombination('O')){
printBox();
System.out.println("You lost the game!\nCreated by Shreyas Saha. Thanks for playing!");
return true;
}
return false;
}

public boolean checkDraw(){
if(!boxAvailable){
printBox();
System.out.println("It's a draw!\nCreated by Shreyas Saha. Thanks for playing!");
return true;
}
return false;
}

public void startGame(){
System.out.println("Enter box number to select. Enjoy!\n");
Scanner scan = new Scanner(System.in);
while (true) {
printBox();
setBoxEmpty();

player1(scan);

checkBoxAvalability();

player2();
if (checkWinner1() || checkWinner2() || checkDraw()) {
break;
}
}
scan.close();
}
}