feat: Add autocomplete="off" to Bind DN/Password and userSearchFilter inputs in LDAPProviderDialog#1224
Open
eduardomozart wants to merge 4 commits intognmyt:mainfrom
Open
Conversation
…copilot/add-autocomplete-off-to-input
…n LDAPProviderDialog Co-authored-by: eduardomozart <2974895+eduardomozart@users.noreply.github.com>
Added autoComplete='off' to input fields for bindDN and bindPassword.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📋 Description
When configuring LDAP integration, browser-based password managers (specifically Bitwarden) incorrectly identify the Bind DN/Password and User Search Filter fields as login credentials.
Browser autocomplete on the userSearchFilter field is inappropriate — it's an LDAP filter expression (e.g. (uid={{username}})), not a user-facing value that benefits from history suggestions.
When navigating to the LDAP Configuration page, Bitwarden and other password managers should ignore these fields entirely, leaving the LDAP search strings intact and preventing accidental credential leakage into the filter configuration.
LDAPProviderDialog.jsx: addsautoComplete="off"to theuserSearchFilterInputonly; all other fields are unchangedThe
IconInputcomponent already forwardsautoCompleteto the underlying<input>element, so no changes to shared components are needed.🚀 Changes made to ...
✅ Checklist
🔗 Related Issues
None.