Skip to content

feat: Add autocomplete="off" to Bind DN/Password and userSearchFilter inputs in LDAPProviderDialog#1224

Open
eduardomozart wants to merge 4 commits intognmyt:mainfrom
eduardomozart:copilot/add-autocomplete-off-to-input
Open

feat: Add autocomplete="off" to Bind DN/Password and userSearchFilter inputs in LDAPProviderDialog#1224
eduardomozart wants to merge 4 commits intognmyt:mainfrom
eduardomozart:copilot/add-autocomplete-off-to-input

Conversation

@eduardomozart
Copy link
Copy Markdown
Contributor

📋 Description

When configuring LDAP integration, browser-based password managers (specifically Bitwarden) incorrectly identify the Bind DN/Password and User Search Filter fields as login credentials.

Browser autocomplete on the userSearchFilter field is inappropriate — it's an LDAP filter expression (e.g. (uid={{username}})), not a user-facing value that benefits from history suggestions.

When navigating to the LDAP Configuration page, Bitwarden and other password managers should ignore these fields entirely, leaving the LDAP search strings intact and preventing accidental credential leakage into the filter configuration.

  • LDAPProviderDialog.jsx: adds autoComplete="off" to the userSearchFilter Input only; all other fields are unchanged
<Input
  icon={mdiFilter}
  placeholder={T("fields.userSearchFilterPlaceholder")}
  value={form.userSearchFilter}
  setValue={set("userSearchFilter")}
  autoComplete="off"   // ← added
/>

The IconInput component already forwards autoComplete to the underlying <input> element, so no changes to shared components are needed.

🚀 Changes made to ...

  • 🔧 Server
  • 🖥️ Client
  • 📚 Documentation
  • 🔄 Other: ___

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have looked for similar pull requests in the repository and found none
  • This pull request does not contain translations (translations are managed through Crowdin)

🔗 Related Issues

None.

Copilot AI and others added 3 commits March 3, 2026 12:40
…n LDAPProviderDialog

Co-authored-by: eduardomozart <2974895+eduardomozart@users.noreply.github.com>
@eduardomozart eduardomozart changed the title feat: Add autocomplete="off" to userSearchFilter input in LDAPProviderDialog feat: Add autocomplete="off" to Bind DN/Password and userSearchFilter inputs in LDAPProviderDialog Mar 3, 2026
Added autoComplete='off' to input fields for bindDN and bindPassword.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants