You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
使用 toasts 有两个问题
There are two issues with using toasts
可能会错过这个错误信息
This error message might be missed
比如我点击发起连接了,然后在等待链接的时候离开座位去拿水喝,等回到座位会会错过错误信息。
For example, if I click to initiate a connection and then leave my seat to get water while waiting for the link, I may miss an error message when I return to my seat.
如果同时向多个服务器发起连接,会不清楚错误信息是哪个服务器的
If connections are initiated to multiple servers simultaneously, it may be unclear which server's error message corresponds to which
我认为一个比较合适的显示方式是不要关闭tab标签,直接把错误信息显示在原来渲染远程画面的地方
I think a more suitable display method is not to close the tab tab, but to directly display the error message in the original location where the remote screen was rendered
I also request that you add logs for successful SSH connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Adds translatable user-friendly error message toasts for the following cases:
Tested against SSH, RDP, VNC.
🚀 Changes made to ...
✅ Checklist
🔗 Related Issues
Fixes #1031