Simplify macOS CI: use stock FUSE-T instead of building libfuse#529
Closed
petemoore wants to merge 1 commit intogittup:masterfrom
Closed
Simplify macOS CI: use stock FUSE-T instead of building libfuse#529petemoore wants to merge 1 commit intogittup:masterfrom
petemoore wants to merge 1 commit intogittup:masterfrom
Conversation
…source The unmount teardown fix (macos-fuse-t/libfuse#11) has landed upstream and shipped in FUSE-T 1.0.54. Remove the custom libfuse build step and use the stock FUSE-T installation directly. Changes: - Remove git clone / cmake build of patched libfuse fork - Remove cmake from brew install (no longer needed) - Use fully qualified tap path to avoid stale Homebrew API cache - Fix libfuse-t.dylib install name (@rpath -> absolute path) - Create fuse.pc with -D_FILE_OFFSET_BITS=64 (FUSE-T's fuse-t.pc doesn't include this flag, but the FUSE headers require it) - Simplify macOS install docs to match Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
Contributor
Author
|
Putting in DRAFT for now, because I think petemoore/libfuse@a4ff4aa may still be needed (the current version on my branch has two fixes, but currently only one has landed upstream). Will do some more testing. |
Contributor
Author
|
I'm going to close this. Even though things work well in the CI, locally I am still having issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The unmount teardown fix (macos-fuse-t/libfuse#11) has landed upstream and shipped in FUSE-T 1.0.54. This removes the custom libfuse build-from-source step and uses the stock FUSE-T installation directly.
cmakefrom brew install (no longer needed)@rpath-> absolute path)fuse.pcwith-D_FILE_OFFSET_BITS=64(FUSE-T'sfuse-t.pcdoesn't include this flag, but the FUSE headers require it)Supersedes #528 (whose changes were already applied to master).
Test plan
🤖 Generated with Claude Code