Conversation
Kernon doesn't currently work with the import function
Commenting out until I chat with Google folks
There was a problem hiding this comment.
Pull request overview
Updates the README to reflect Mona Sans’ expanded design space, including the addition of Display Italic masters, and removes outdated usage guidance.
Changes:
- Updates the documented instance count and mentions “display italic” in the design space overview.
- Removes guidance about choosing a smaller variable font file subset.
- Minor markdown formatting change (additional blank line).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Mona Sans Styles | ||
|
|
||
| With the newly added monospace and display styles, Mona Sans’ design space now spans 128 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. | ||
| With the newly added monospace, display, and display italic styles, Mona Sans' design space now spans 168 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. |
There was a problem hiding this comment.
The text claims the map below represents the whole space including the newly added “display italic” styles, but the visible mapping table section only names “Display” under opsz and doesn’t document any “Display Italic” style entry. Either extend the table/map to include how Display Italic is represented, or reword the sentence to clarify that the table is only describing specific axes (e.g., opsz) and that Display Italic isn’t a separate named entry here.
| With the newly added monospace, display, and display italic styles, Mona Sans' design space now spans 168 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. | |
| With the newly added monospace, display, and display italic styles, Mona Sans' design space now spans 168 instances. Below is a map of the registered axis values in that space. Display italic styles are represented by combining the Display optical size (opsz 72) with Italic (ital 1). Style entries with a hyphen are elidable, meaning they are the default and have no name. |
| @@ -114,6 +112,7 @@ With the newly added monospace and display styles, Mona Sans’ design space now | |||
| | Optical Size (opsz) | 20 | - | | |||
| | - | 72 | Display | | |||
There was a problem hiding this comment.
The text claims the map below represents the whole space including the newly added “display italic” styles, but the visible mapping table section only names “Display” under opsz and doesn’t document any “Display Italic” style entry. Either extend the table/map to include how Display Italic is represented, or reword the sentence to clarify that the table is only describing specific axes (e.g., opsz) and that Display Italic isn’t a separate named entry here.
| | - | 72 | Display | | |
| | - | 72 | Display | | |
| | Display Italic style | opsz 72 + ital 1 | Display Italic | |
| ## Mona Sans Styles | ||
|
|
||
| With the newly added monospace and display styles, Mona Sans’ design space now spans 128 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. | ||
| With the newly added monospace, display, and display italic styles, Mona Sans' design space now spans 168 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. |
There was a problem hiding this comment.
For consistency with the style naming used elsewhere in the document/table (e.g., “Display”), consider capitalizing the style names in this sentence (e.g., “Monospace”, “Display”, “Display Italic”).
| With the newly added monospace, display, and display italic styles, Mona Sans' design space now spans 168 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. | |
| With the newly added Monospace, Display, and Display Italic styles, Mona Sans' design space now spans 168 instances. Below is a map for the whole space. Style entries with a hyphen are elidable, meaning they are the default and have no name. |
| | Optical Size (opsz) | 20 | - | | ||
| | - | 72 | Display | | ||
|
|
||
|
|
There was a problem hiding this comment.
There’s an extra blank line added before the “### Mona Sans Monospace Styles” heading. If it’s not intentionally separating sections (e.g., to satisfy a markdown linter), consider removing it to keep formatting changes minimal.
This pull request updates the
README.mdto reflect recent changes to the Mona Sans font family, specifically the addition of Display Italic masters and a clarification in the usage documentation. The most notable updates are the documentation of new font variants and a cleanup of outdated instructions.