feat(python): add overloads for CopilotClient.on()#589
Open
brettcannon wants to merge 5 commits intogithub:mainfrom
Open
feat(python): add overloads for CopilotClient.on()#589brettcannon wants to merge 5 commits intogithub:mainfrom
CopilotClient.on()#589brettcannon wants to merge 5 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Python typing improvements for CopilotClient.on() by introducing overloads for its two supported call patterns and making the first argument positional-only to discourage meaningless keyword usage.
Changes:
- Added
@overloadsignatures forCopilotClient.on()to distinguishon(handler)vson(event_type, handler). - Made the first
on()parameter positional-only (/) in the implementation signature.
SteveSandersonMS
previously approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the way, make the first argument positional-only since the parameter name does not make sense to specify as a keyword argument.