apprt/gtk: remove explicit X11 clipboard atom#9570
apprt/gtk: remove explicit X11 clipboard atom#9570mitchellh merged 1 commit intoghostty-org:mainfrom
Conversation
Turns out this was not needed after all and GTK adds it automatically when running under X11; just having the explicit UTF-8 charset type is enough. This corrects situations where it may not be necessary to include (Wayland), in addition to removing a duplicate atom under X11. Importantly, this also corrects issues under Wayland in some scenarios, such as using Electron-based apps (e.g., VSCode/Codium under Ubuntu 24.04 LTS).
67ccde2 to
4f6c5a8
Compare
mitchellh
left a comment
There was a problem hiding this comment.
Thank you so much for the diligence on this!
|
No problem @mitchellh! Another small addendum: I just decided to check foot, and they offer UTF-8 first, along with the X11 atoms (offered last). However, pretty sure my assumption about the actual selected type being up to the client still stands: (https://wayland.freedesktop.org/docs/html/ch04.html#sect-Protocol-data-sharing)
So we got some extra context here in the event that we see more clients misbehave than not and we actually do need to adjust the order (or actually add the X11 atoms in Wayland). |
Fixes #9532
Supersedes #9554
Turns out the explicit
UTF8_STRINGatom was not needed after all and GTK adds it automatically when running under X11; just having the explicit UTF-8 charset type is enough.This corrects situations where it may not be necessary to include (Wayland), in addition to removing a duplicate atom under X11.
Importantly, this also corrects issues under Wayland in some scenarios, such as using Electron-based apps (e.g., VSCode/Codium under Ubuntu 24.04 LTS).