build: skip ghostty-test graph when building libghostty-vt#12224
Merged
jcollie merged 1 commit intoghostty-org:mainfrom Apr 10, 2026
Merged
build: skip ghostty-test graph when building libghostty-vt#12224jcollie merged 1 commit intoghostty-org:mainfrom
jcollie merged 1 commit intoghostty-org:mainfrom
Conversation
Contributor
|
Hi @kataokatsuki, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
Member
|
Looks like GH wasn't fast enough to add you to the vouched list. |
Contributor
Author
|
Thanks for reopening! |
Contributor
|
Going to close and reopen to try to kick GitHub actions in the ass. |
Contributor
|
CI is very sad and its not this PRs fault. We should wait until some dust settles to re run. |
jcollie
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12151
When
emit_lib_vtis true, the// Testsblock was stillevaluated, pulling in the full ghostty-test dependency graph
(freetype, zlib, dcimgui, etc.). This causes the Nix
libghostty-vtpackage to fail whendoCheckis enabled,since those system libraries aren't available in the sandbox.
Guard the block with
if (!config.emit_lib_vt), followingthe existing pattern at line 179.