build: add ghostty-internal pkg-config modules (shared + static)#12214
build: add ghostty-internal pkg-config modules (shared + static)#12214deblasis wants to merge 1 commit intoghostty-org:mainfrom
Conversation
|
If this one lands, next one would be to create a "fat archive" for windows as well. I will 90% hit a wall with NativeAOT on windows with winui3 but regardless, that's something MS is supposedly working on. UpdateI hit the wall eventually but found workarounds and managed to get a single executable for Ghostty Windows! I filed an issue upstream for anyone else bumping into the same problem: microsoft/WindowsAppSDK#6394 |
|
Lets rename these to
|
mitchellh
left a comment
There was a problem hiding this comment.
Blocked on some naming.
b2935cb to
66ffe8f
Compare
66ffe8f to
dd04856
Compare
| return if (os_tag == .windows) | ||
| "ghostty-static.lib" | ||
| else | ||
| "libghostty.a"; |
There was a problem hiding this comment.
Let's rename this too. And anywhere else we write it out, let's use this PR to fix it up.
Summary
Mirror the
libghostty-vt-staticpkg-config pattern from #12210 for the internal library.ghostty-internal.pc(shared,-lghostty) andghostty-internal-static.pc(static, direct archive reference) so consumers can discover either variant via pkg-configghostty-internalto distinguish from the publiclibghostty-vtAPIghostty-static.libon Windows,libghostty.aelsewhere)GhosttyLib.install()Test plan
zig buildsucceeds (default target)ghostty-internal.pcandghostty-internal-static.pcappear inzig-out/share/pkgconfig/.pcpoints atghostty-static.lib(Windows) /libghostty.a(Unix).pcuses standard-L -lflagslibghostty-vtpkg-config files are unaffected